This repository has been archived by the owner on Jul 16, 2019. It is now read-only.
Add tests for single-dataframe merge #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This relies on some changes upstream, notably ... - dask/dask#4522 - rapidsai/cudf#1031 for which I have a hacky solution here: rapidsai/cudf@branch-0.6...mrocklin:merge-keywords-hack
|
@randerzander checking in. Does this approach solve your problem? |
|
If not targeted for v0.6 release please change the base to |
kkraus14
approved these changes
May 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relies on some changes upstream, notably ...
Make merge dispatchable on pandas/other dataframe types dask/dask#4522
[FEA] Support additional merge keywords left/right_on, indicator, suffixes cudf#1031
for which I have a hacky solution here:
rapidsai/cudf@branch-0.6...mrocklin:merge-keywords-hack
cc @randerzander after the changes above you should be able to use the standard
dask.dataframe.mergefunction on dask-cudf dataframes if at least one of them has a single partition.