Make merge dispatchable on pandas/other dataframe types#4522
Merged
mrocklin merged 8 commits intodask:masterfrom Feb 26, 2019
Merged
Make merge dispatchable on pandas/other dataframe types#4522mrocklin merged 8 commits intodask:masterfrom
mrocklin merged 8 commits intodask:masterfrom
Conversation
Closed
mrocklin
added a commit
to mrocklin/dask-cudf
that referenced
this pull request
Feb 22, 2019
This relies on some changes upstream, notably ... - dask/dask#4522 - rapidsai/cudf#1031 for which I have a hacky solution here: rapidsai/cudf@branch-0.6...mrocklin:merge-keywords-hack
Member
Author
|
I've also removed a fair bit of special-cased code that was, I suspect, necessary for older versions of Pandas but is no longer needed. |
mrocklin
changed the title
Member
Author
|
@jcrist are you comfortable with these changes? |
Member
|
Fine by me, nice to see that this could be done easily without adding an additional dependency. |
jorge-pessoa
pushed a commit
to jorge-pessoa/dask
that referenced
this pull request
May 14, 2019
kkraus14
pushed a commit
to rapidsai/dask-cudf
that referenced
this pull request
May 14, 2019
This relies on some changes upstream, notably ... - dask/dask#4522 - rapidsai/cudf#1031 for which I have a hacky solution here: rapidsai/cudf@branch-0.6...mrocklin:merge-keywords-hack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion in #4521
flake8 dask