Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to clang-format 18 #341

Closed
bernhardmgruber opened this issue Jul 3, 2024 · 2 comments · Fixed by #343
Closed

Move to clang-format 18 #341

bernhardmgruber opened this issue Jul 3, 2024 · 2 comments · Fixed by #343

Comments

@bernhardmgruber
Copy link
Contributor

Our CCCL pre-commit informed us of an available update that includes moving from clang-format 17.0.6 to 18.1.8. @jrhemstad pointed out this needs to be synced with the version installed in the devcontainers, so developers will have a good experience of getting the same formatting locally as what the CI checks for. Hence this issue.

I kindly ask to upgrade the clang-format version to the latest 18 release in devcontainers. We can then fix the pre-commit clang-format version to that version.

@trxcllnt
Copy link
Collaborator

trxcllnt commented Jul 3, 2024

You can bump the CCCL clang format version by updating this line in the image matrix.

bernhardmgruber added a commit to bernhardmgruber/devcontainers that referenced this issue Jul 3, 2024
@bernhardmgruber
Copy link
Contributor Author

Thx a lot! PR is here: #343

trxcllnt pushed a commit that referenced this issue Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants