Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set version when dlopen() cuda and cufile #127

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Sep 1, 2022

In order to avoid ABI incompatibilities and loading of stub libraries, we now specify the major version when loading libcuda.so.1 and libcufile.so.1.

@madsbk madsbk added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Sep 1, 2022
@madsbk madsbk marked this pull request as ready for review September 1, 2022 12:00
@quasiben
Copy link
Member

quasiben commented Sep 1, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 049e958 into rapidsai:branch-22.10 Sep 1, 2022
@madsbk madsbk deleted the dlopen_use_version branch January 13, 2023 08:28
wence- added a commit to wence-/kvikio that referenced this pull request Apr 25, 2023
Rather than searching for a list of possible library names for
libcufile, only look for the single ABI-compatible version of
libcufile that we support. This avoids both ABI incompatibilities and
loading stub libraries. It morally does what rapidsai#127 attempted, but with
the correct versioning suffix.
rapids-bot bot pushed a commit that referenced this pull request Apr 26, 2023
Rather than searching for a list of possible library names for libcufile, only look for the single ABI-compatible version of libcufile that we support. This avoids both ABI incompatibilities and loading stub libraries. It morally does what #127 attempted, but with the correct versioning suffix.

Closes #200.

Authors:
  - Lawrence Mitchell (https://github.com/wence-)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Mads R. B. Kristensen (https://github.com/madsbk)

URL: #203
vuule pushed a commit to vuule/kvikio that referenced this pull request Nov 8, 2023
Fixes `AttributeError: __enter__` for `pandas.read_sas` that returns an object with `__enter__`

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

URL: rapidsai/cudf-private#127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants