Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone Downstream C++ Build Example #29

Merged
merged 15 commits into from
Sep 8, 2022

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Mar 17, 2022

Implement an example of using KvikIO by a downstream C++ project.

The example use get_kvikio.cmake to download and use the KvikIO headers:

# Find KvikIO
include(cmake/get_kvikio.cmake)

rapids_find_package(
  KvikIO REQUIRED
  BUILD_EXPORT_SET downstream-example-exports
  INSTALL_EXPORT_SET downstream-example-exports
)

target_include_directories(downstream_example PRIVATE ${KvikIO_INCLUDE_DIR})

@madsbk madsbk force-pushed the standalone_cpp_example branch 2 times, most recently from 740a8d6 to b18e1c1 Compare March 18, 2022 08:55
@madsbk madsbk added improvement Improves an existing functionality non-breaking Introduces a non-breaking change c++ Affects the C++ API of KvikIO labels Mar 18, 2022
@madsbk madsbk marked this pull request as ready for review March 18, 2022 09:07
@madsbk madsbk force-pushed the standalone_cpp_example branch 2 times, most recently from d9314bc to 909d30d Compare March 21, 2022 07:28
@jakirkham
Copy link
Member

Just a note, this is being moved to 22.06

@jakirkham jakirkham changed the base branch from branch-22.04 to branch-22.06 April 4, 2022 17:34
@jakirkham
Copy link
Member

Changed the base branch to branch-22.06

@jakirkham
Copy link
Member

@madsbk did we want to get this in 22.08 or do we want to bump to 22.10?

@madsbk madsbk changed the base branch from branch-22.06 to branch-22.10 August 3, 2022 14:20
@madsbk
Copy link
Member Author

madsbk commented Aug 3, 2022

@madsbk did we want to get this in 22.08 or do we want to bump to 22.10?

Let's target v22.10

@rapidsai rapidsai deleted a comment from jakirkham Sep 5, 2022
@robertmaynard
Copy link
Contributor

Personally I don't think we should use rapids-cmake in examples of how consumers can use projects. In my expereience doing so makes people think projects aren't usable from consumers don't use rapids-cmake.

@madsbk
Copy link
Member Author

madsbk commented Sep 6, 2022

Personally I don't think we should use rapids-cmake in examples of how consumers can use projects. In my expereience doing so makes people think projects aren't usable from consumers don't use rapids-cmake.

Thanks, I have simplified the example. Anything else we should change?

Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change, otherwise looks excellent!

cpp/examples/downstream/cmake/get_kvikio.cmake Outdated Show resolved Hide resolved
ci/gpu/build.sh Outdated Show resolved Hide resolved
Co-authored-by: Robert Maynard <robertjmaynard@gmail.com>
@madsbk
Copy link
Member Author

madsbk commented Sep 8, 2022

Thanks @robertmaynard, anything else?

@quasiben
Copy link
Member

quasiben commented Sep 8, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f8f4063 into rapidsai:branch-22.10 Sep 8, 2022
@madsbk madsbk deleted the standalone_cpp_example branch March 21, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Affects the C++ API of KvikIO improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants