Specify correct global targets names to raft_export #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The raft_nn and raft_distance targets are exported with the names nn and distance, therefore those are the names that need to be marked as GLOBAL.
robertmaynard
added
bug
cjnolet
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
You should be able to use the new git pre-commit hooks to make the style checker happy: https://docs.rapids.ai/api/raft/nightly/contributing.html#python-pre-commit-hooks
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The raft_nn and raft_distance targets are exported with the names nn and distance, therefore those are the names that need to be marked as GLOBAL.