Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable host dataset for IVF-Flat #1635

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Enable host dataset for IVF-Flat #1635

merged 4 commits into from
Nov 28, 2023

Conversation

tfeher
Copy link
Contributor

@tfeher tfeher commented Jul 5, 2023

Enable host input data for IVF-Flat build.

This is done by batch-wise processing the dataset during extend, similarly how IVF-PQ does it.

@github-actions github-actions bot added the cpp label Jul 5, 2023
@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 6, 2023
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 16, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@cjnolet cjnolet changed the base branch from branch-23.08 to branch-23.12 November 17, 2023 01:07
@cjnolet
Copy link
Member

cjnolet commented Nov 17, 2023

/ok to test

@tfeher tfeher marked this pull request as ready for review November 19, 2023 23:52
@tfeher tfeher requested review from a team as code owners November 19, 2023 23:52
@github-actions github-actions bot removed the CMake label Nov 20, 2023
@cjnolet
Copy link
Member

cjnolet commented Nov 20, 2023

/ok to test

@tfeher
Copy link
Contributor Author

tfeher commented Nov 20, 2023

Squashed the PR to a single commit to remove unsigned ones.

@tfeher tfeher changed the base branch from branch-23.12 to branch-24.02 November 27, 2023 09:58
cjnolet
cjnolet approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cjnolet
Copy link
Member

cjnolet commented Nov 28, 2023

/merge

@rapids-bot rapids-bot bot merged commit 88e9a55 into rapidsai:branch-24.02 Nov 28, 2023
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees

@tfeher tfeher

Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Vector Search
Projects
VS/ML/DM Primitives Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tfeher @cjnolet