Pin dask versions in CI
#260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajschmidt8
added
improvement
dantegd
approved these changes
Jun 8, 2021
pentschev
suggested changes
Jun 8, 2021
Comment on lines
+62
to
+63
| pip install "git+https://github.com/dask/distributed.git@2021.05.1" --upgrade --no-deps | ||
| pip install "git+https://github.com/dask/dask.git@2021.05.1" --upgrade --no-deps |
There was a problem hiding this comment.
Suggested change
| pip install "git+https://github.com/dask/distributed.git@2021.05.1" --upgrade --no-deps | |
| pip install "git+https://github.com/dask/dask.git@2021.05.1" --upgrade --no-deps |
There was a problem hiding this comment.
We shouldn't need to install again, it's already installed from conda.
There was a problem hiding this comment.
The reason it is being pip installed is to test against main
There was a problem hiding this comment.
Yes, but we can't test against main in branch-21.06 anymore, only branch-21.08 should do so.
There was a problem hiding this comment.
Fair enough. Either should be fine
The primary thing is making sure we don't forget to add this back to branch-21.08 (with main being used)
There was a problem hiding this comment.
Yeah, we should follow-up with a PR immediately after this lands, as we did for other libraries yesterday.
Comment on lines
+83
to
+86
| set -x | ||
| pip install "git+https://github.com/dask/distributed.git@2021.05.1" --upgrade --no-deps | ||
| pip install "git+https://github.com/dask/dask.git@2021.05.1" --upgrade --no-deps | ||
| set +x |
There was a problem hiding this comment.
Suggested change
| set -x | |
| pip install "git+https://github.com/dask/distributed.git@2021.05.1" --upgrade --no-deps | |
| pip install "git+https://github.com/dask/dask.git@2021.05.1" --upgrade --no-deps | |
| set +x |
pentschev
approved these changes
Jun 8, 2021
jakirkham
approved these changes
Jun 8, 2021
dillon-cullinan
approved these changes
Jun 8, 2021
raydouglass
approved these changes
Jun 8, 2021
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 10, 2021
This PR reverts the pins that were made in #260. Those changes were only needed for the `21.06` branch. Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) - Dillon Cullinan (https://github.com/dillon-cullinan) URL: #264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to https://github.com/rapidsai/cuml/pull/3937/files, this PR pins the version of
daskanddistributedthat's used in CI.