Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the 21.08 branch of rapids-cmake as rmm requires it #278

Merged

Conversation

robertmaynard
Copy link
Contributor

Now that rmm uses rapids-cmake we need to update to the 21.08 branch to get the new rapids_cmake_write_version_file function

@dantegd
Copy link
Member

dantegd commented Jun 22, 2021

Before RMM's migration to rapids-cmake RAFT's CMake was just relying on RMM's for all of thrust's build needs, but now this is running into

CMake Error at /opt/conda/envs/rapids/lib/cmake/rmm/rmm-config.cmake:122 (thrust_create_target):
  Unknown CMake command "thrust_create_target".

Does that mean that we need a get_thrust in raft (like cuML's)?

@robertmaynard
Copy link
Contributor Author

Before RMM's migration to rapids-cmake RAFT's CMake was just relying on RMM's for all of thrust's build needs, but now this is running into

CMake Error at /opt/conda/envs/rapids/lib/cmake/rmm/rmm-config.cmake:122 (thrust_create_target):
  Unknown CMake command "thrust_create_target".

Does that mean that we need a get_thrust in raft (like cuML's)?

Yes that is the easiest way to make sure we pull a version of Thrust of the sufficient version that has that CMake function. I have updated this PR to do this.

@dantegd dantegd added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 22, 2021
@dantegd
Copy link
Member

dantegd commented Jun 22, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2ba5d76 into rapidsai:branch-21.08 Jun 22, 2021
@robertmaynard robertmaynard deleted the use_rapids_cmake_21.08 branch June 22, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants