Accounting for rmm::cuda_stream_pool not having a constructor for 0 streams #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyegala
added
3 - Ready for Review
bug
ChuckHastings
approved these changes
Sep 17, 2021
dantegd
approved these changes
Sep 17, 2021
divyegala
commented
Sep 17, 2021
| @@ -64,18 +62,6 @@ TEST(Raft, GetHandleFromPool) { | |||
| ASSERT_EQ(parent.get_device(), child.get_device()); | |||
| } | |||
|
|
|||
| TEST(Raft, GetHandleFromPoolPerf) { | |||
There was a problem hiding this comment.
I had to remove this test because for some reason, the destructor for parent was being called while in the for loop. Since this is just a temporary fix, and my handle refactor will take care of the copy constructor for raft::handle_t, we should be fine
ChuckHastings
approved these changes
Sep 17, 2021
dantegd
approved these changes
Sep 17, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comes from this PR rapidsai/rmm#873