Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Define PTDS via -D to fix cache misses in sccache #476

Merged
merged 1 commit into from
Feb 1, 2022
Merged

[FIX] Define PTDS via -D to fix cache misses in sccache #476

merged 1 commit into from
Feb 1, 2022

Conversation

trxcllnt
Copy link
Collaborator

@trxcllnt trxcllnt commented Feb 1, 2022

Define PTDS via -DCUDA_API_PER_THREAD_DEFAULT_STREAM because sccache doesn't recognize the --default-stream per-thread arg yet.

@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 1, 2022
@robertmaynard
Copy link
Contributor

@trxcllnt Can you file a bug on sccache for this flag, so we know when it is safe to switch back to it

@ajschmidt8
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit fc76bcc into rapidsai:branch-22.04 Feb 1, 2022
@trxcllnt
Copy link
Collaborator Author

trxcllnt commented Feb 2, 2022

mozilla/sccache#1105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trxcllnt @robertmaynard @ajschmidt8 @cjnolet