Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] RNG API fixes #630

Merged
merged 3 commits into from
Apr 27, 2022
Merged

Conversation

MatthiasKohl
Copy link
Contributor

After merging PR #609 , I realized that there were still a few bugs (all minor):

  1. The deprecated Rng class had the type attribute removed. I added it back. This was used in cugraph-ops but not in other projects (cugraph, cuml).
  2. The template function to call another function with the device state was actually unusable since you wouldn't be able to instantiate a function to call it with. So I removed that.
  3. The macro used to call functions with a device state wasn't using fully namespace-qualified names, which made it unusable outside of RAFT.
  4. Removed the deprecation warning of the new rng_device.cuh since it has to be included anyway through rng.cuh, so those deprecations didn't make sense.

@MatthiasKohl MatthiasKohl requested a review from a team as a code owner April 26, 2022 16:30
@github-actions github-actions bot added the cpp label Apr 26, 2022
@MatthiasKohl MatthiasKohl added bug Something isn't working 3 - Ready for Review non-breaking Non-breaking change and removed cpp labels Apr 26, 2022
@MatthiasKohl
Copy link
Contributor Author

rerun tests

1 similar comment
@MatthiasKohl
Copy link
Contributor Author

rerun tests

@cjnolet
Copy link
Member

cjnolet commented Apr 27, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f487da7 into rapidsai:branch-22.06 Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants