Build pylibraft with scikit-build #633
Conversation
|
For some reason |
# Conflicts: # build.sh # conda/recipes/pylibraft/build.sh
|
This PR should not be merged until we resolve rapidsai/rapids-cmake#189. For the case where we're building the Python library without a preexisting build of the C++ lib, we need to come up with a standard scheme for how we package up the C++ library and link to it. |
…ibrary without the distance component.
No worries, thanks for the review. We're nearly there, but we have a couple of blockers to resolve (the rapids-cmake issue above and maybe a better way to handle the case where we're linking to a libraft without distances compiled in). |
|
This PR depends on rapidsai/rapids-cmake#189, and if someone on the raft team is used to building raft on bare metal I'd appreciate a tester of building both with and without a preexisting C++ library just to be sure that everything is behaving as expected. I am running into one issue locally, but I'm having trouble isolating whether it's because I'm using rapids-compose or not. |
|
I confirmed that the above issue is not related to rapids-compose. I can reproduce it on bare metal, so I'll need to track this down. |
|
OK I think this PR is all set now. There were errors in the configuration of the CUDA architectures when the C++ library build was triggered by the Python build, now that has been fixed. Tests won't pass here until we merge rapidsai/rapids-cmake#189, but then this PR should be good to go. |
|
rerun tests |
|
@gpucibot merge |
This PR changes the pyraft build system to use scikit-build and CMake. It depends on the changes in #633 and should be merged after that PR. This PR is largely complete, except that I am not yet sure exactly which libraries/headers are entirely necessary for the build. This version builds locally for me, but not all tests pass since I don't have nccl. However, I am a bit surprised to see the build succeeding without me even searching for UCX (perhaps this is because it's already on my system include path) so I need to figure out what do with UCX, NCCL, and the various CUDA math libraries (cusparse, cublas, etc). Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Sevag Hanssian (https://github.com/sevagh) - Ray Douglass (https://github.com/raydouglass) - Corey J. Nolet (https://github.com/cjnolet) URL: #644
This PR fixes a number of small errors that slipped through in #644 and #633. None of them materially affect the build (whether a preexisting libraft exists or not) since 1) benchmarks are currently turned off by default anyway in the C++ build, and 2) pyraft only depends on libraft for headers, not for compiled libraries. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #662
This PR changes the build system for pylibraft to use scikit-build and CMake, allowing it to standardize more logic across all of RAPIDS and leverage the benefits of CMake to simplify building the C++ libraries along with the Python packages.