Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating raft rng host public API and adding docs #636

Merged
merged 12 commits into from
May 5, 2022
Merged

Updating raft rng host public API and adding docs #636

merged 12 commits into from
May 5, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented May 3, 2022

No description provided.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 3, 2022
@cjnolet cjnolet requested a review from a team as a code owner May 3, 2022 21:13
@cjnolet cjnolet self-assigned this May 3, 2022
@github-actions github-actions bot added the cpp label May 3, 2022
divyegala
divyegala approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think there’s a few empty ‘TearDown’ functions in gtests, and I’m okay either way if they are removed or not.

cpp/test/linalg/reduce_cols_by_key.cu Outdated Show resolved Hide resolved
@cjnolet
Copy link
Member Author

cjnolet commented May 5, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit beeee1e into rapidsai:branch-22.06 May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

Assignees

@cjnolet cjnolet

Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjnolet @divyegala