Revert print vector changes because of std::vector<bool> #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowener
added
bug
achirkin
requested changes
May 25, 2022
| CUDA_CHECK( | ||
| cudaMemcpy(host_mem.data(), devMem, componentsCount * sizeof(T), cudaMemcpyDeviceToHost)); | ||
| print_host_vector(variable_name, host_mem.data(), componentsCount, out); | ||
| T* host_mem = new T[componentsCount]; |
There was a problem hiding this comment.
I'd suggest to use unique_ptr to avoid a memory leak on exception, e.g.
auto host_mem = std::make_unique<T[]>(componentsCount);
cjnolet
approved these changes
May 26, 2022
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 1, 2022
Continuation of #681 Authors: - Micka (https://github.com/lowener) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #695
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specialization of
std::vectorwhenT=boolis unfortunately causing compilation issue in cuml because thedata()function member is not implemented. And the elements may not be stored contiguously.(Link to the CI failure: https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cuml/job/prb/job/cuml-cpu-cuda-build-arm64/CUDA=11.5/1364/console)
cc @achirkin