Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 32bit and unsigned indices in bruteforce KNN #730

Merged
merged 3 commits into from
Jul 5, 2022
Merged

Support 32bit and unsigned indices in bruteforce KNN #730

merged 3 commits into from
Jul 5, 2022

Conversation

achirkin
Copy link
Contributor

@achirkin achirkin commented Jul 1, 2022

Make KNN compilable with IdxT == uint32_t and add some benchmarks.

@achirkin achirkin requested review from a team as code owners July 1, 2022 09:52
@achirkin achirkin added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change 3 - Ready for Review labels Jul 1, 2022
@achirkin
Copy link
Contributor Author

achirkin commented Jul 1, 2022

NB: this PR is required before merging #652, which expands on the benchmarks introduced here (trying to reduce the size of #652).

@achirkin achirkin mentioned this pull request Jul 1, 2022
Merged
robertmaynard
robertmaynard approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake changes LGTM

@achirkin
Copy link
Contributor Author

achirkin commented Jul 4, 2022

rerun tests

tfeher
tfeher requested changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@tfeher tfeher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @achirkin, thanks for the PR, it looks good, just a small thing.

cpp/include/raft/spatial/knn/detail/haversine_distance.cuh Show resolved Hide resolved
cpp/bench/spatial/knn.cu Outdated Show resolved Hide resolved
achirkin and others added 2 commits July 4, 2022 13:58
@achirkin @tfeher
Update cpp/bench/spatial/knn.cu
1773a4d 
Co-authored-by: Tamas Bela Feher <tfeher@nvidia.com>
@achirkin
Fix style
62109bd
tfeher
tfeher approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Artem for addressing the issue, the PR looks good to me.

@cjnolet
Copy link
Member

cjnolet commented Jul 5, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8aae19f into rapidsai:branch-22.08 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfeher tfeher tfeher approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@achirkin @cjnolet @robertmaynard @tfeher