fix logic bug in include_checker.py utility #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current if statement always evaluates to false, so no files get checked
Looks like I spoke to soon! The CI found several issues in files under cpp/include. I think I had only run it on cpp/src when testing locally. It looks like logic to exclude the |
cjnolet
added
improvement
|
Okay, style check is passing now. (The |
cjnolet
approved these changes
Jul 8, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I noticed an issue in the include style checker when I was trying to adapt it for use in another project.
As far as I can tell, the current logic results in no source files actually being checked! Fortunately, the script also passes after the proposed change, so the includes were already in good shape :)
I verified the fix here by changing a <...>-style import to a double-quote one in one of the source files and it was detected.
I don't know if this file originates in RAFT or if it is also in other RAPIDS projects as well? If the later, the fix will need to be propagated to other repositories.