Remove type punning from TxN_t #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhoemmen
reviewed
Aug 17, 2022
cjnolet
approved these changes
Aug 23, 2022
mhoemmen
approved these changes
Aug 23, 2022
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 25, 2022
The recent removal of the union-based type punning in #781 caused misaligned access in some cases. This PR returns the alignment to the data type. Authors: - Artem M. Chirkin (https://github.com/achirkin) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - William Hicks (https://github.com/wphicks) URL: #792
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid undefined behavior related to accessing inactive union members in TxN_t