[REVIEW] Mdspanify permute #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhoemmen
added
feature request
mhoemmen
force-pushed
the
mdspanify-permute
branch
2 times, most recently
from
6b8a6ce
to
5f99839
Compare
Add overloads of permute that take arrays as mdspan (std::optional<mdspan<...>> if the array is an optional output argument). Improve documentation of the existing overload and document the new overloads. Add tests. Make sure that the function compiles if users pass in std::nullopt for either or both optional arguments.
mhoemmen
force-pushed
the
mdspanify-permute
branch
from
5f99839
to
4d8d135
Compare
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an overload of
raft::random::permutethat takes device mdspan instead of raw arrays, andstd::optional<mdspan<...>>for optional output arrays. I also added two overloads that let users pass instd::nullopt.I've added a unit test that imitates the existing unit test for the raw-array overloads; it builds and passes. The test ensures that the two
std::nulloptoverloads also compile.I also opportunistically fixed some unrelated existing small build errors that were blocking forward progress. That commit is included in PRs #830 and #833 as well, so if it merges, the change should rebase correctly.