Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update raft tests to compile with C++17 features enabled #973

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Update raft tests to compile with C++17 features enabled #973

merged 1 commit into from
Nov 1, 2022

Conversation

robertmaynard
Copy link
Contributor

The raft tests require C++17 features but doesn't request this compiler mode, so compilation will fail with compilers that default to 11 or 14.

@robertmaynard
Update raft tests to compile with C++17 features enabled
d088862 
The raft tests require C++17 features but doesn't request
this compiler mode, so compilation will fail with compilers
that default to 11 or 14.
@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review non-breaking Non-breaking change labels Nov 1, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner November 1, 2022 15:43
@robertmaynard robertmaynard added this to PR-WIP in RAFT v22.12 Release via automation Nov 1, 2022
@robertmaynard
Copy link
Contributor Author

Encountered locally when building with gcc-9 which defaults to c++14

RAFT v22.12 Release automation moved this from PR-WIP to PR-Reviewer approved Nov 1, 2022
cjnolet
cjnolet approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this!

@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 93a4273 into rapidsai:branch-22.12 Nov 1, 2022
RAFT v22.12 Release automation moved this from PR-Reviewer approved to Done Nov 1, 2022
@robertmaynard robertmaynard deleted the bug/mark_tests_as_needing_c++17 branch November 30, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review bug Something isn't working CMake cpp non-breaking Non-breaking change
Projects
No open projects
RAFT v22.12 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@robertmaynard @cjnolet