Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Make RMM a header-only library #408

Closed
jrhemstad opened this issue Jun 16, 2020 · 1 comment
Closed

[FEA] Make RMM a header-only library #408

jrhemstad opened this issue Jun 16, 2020 · 1 comment
Labels
feature request New feature or request

Comments

@jrhemstad
Copy link
Contributor

jrhemstad commented Jun 16, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.

I would like to simplify the build and deployment of RMM by making it a header-only library.

After #396 and #407, RMM has no components that need to be built into a shared object file.

Additional context

If like me you're wondering, "Does the default resource machinery with function local statics prevent RMM from being able to be header only?", then I already verified that yes, it works as intended. See: https://github.com/jrhemstad/link_test
@jrhemstad jrhemstad added the feature request New feature or request label Jun 16, 2020
@jrhemstad jrhemstad mentioned this issue Jul 8, 2020
Merged
@hcho3 hcho3 mentioned this issue Aug 2, 2020
Closed
@harrism harrism mentioned this issue Aug 5, 2020
Merged
@harrism
Copy link
Member

harrism commented Oct 19, 2020

This is implemented.

@harrism harrism closed this as completed Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@harrism @jrhemstad