Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DeviceBuffer docs. #1090

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Aug 22, 2022

Description

I noticed a few errors in the DeviceBuffer docs while using Python's help(rmm.DeviceBuffer). These errors probably weren't noticed because the docs for DeviceBuffer are not publicly exposed. Reviewers: Should we check to ensure that we are exposing docs for this class and other APIs in the rmm.* Python namespace, and add those (in a separate PR)?

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner August 22, 2022 21:02
@github-actions github-actions bot added the Python Related to RMM Python API label Aug 22, 2022
@bdice bdice added doc Documentation non-breaking Non-breaking change labels Aug 22, 2022
@bdice bdice self-assigned this Aug 22, 2022
@bdice
Copy link
Contributor Author

bdice commented Aug 22, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 45f60da into rapidsai:branch-22.10 Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Non-breaking change Python Related to RMM Python API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants