Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ninja & Update CI environment variables #1155

Merged
merged 5 commits into from
Nov 9, 2022
Merged

Add ninja & Update CI environment variables #1155

merged 5 commits into from
Nov 9, 2022

Conversation

ajschmidt8
Copy link
Member

@ajschmidt8 ajschmidt8 commented Nov 9, 2022 •
edited
Loading

Description

This PR removes some environment variables that will now be defined in our CI images once rapidsai/ci-imgs#19 is merged.

Additionally, it adds ninja to our build requirements since ninja was removed from our CI images.

Depends on rapidsai/ci-imgs#19 and rapidsai/ci-imgs#20.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@ajschmidt8
Update CI environment variables
2a5746b 
This PR removes some environment variables that will now be defined in our CI images once rapidsai/ci-imgs#19 is merged.

Depends on rapidsai/ci-imgs#19.
@ajschmidt8 ajschmidt8 added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Nov 9, 2022
@ajschmidt8 ajschmidt8 mentioned this pull request Nov 9, 2022
Merged
20 tasks
@github-actions github-actions bot removed the ci label Nov 9, 2022
@ajschmidt8 ajschmidt8 mentioned this pull request Nov 9, 2022
Merged
@ajschmidt8 ajschmidt8 changed the title Update CI environment variables Add ninja & Update CI environment variables Nov 9, 2022
@ajschmidt8 ajschmidt8 marked this pull request as ready for review November 9, 2022 21:03
@ajschmidt8 ajschmidt8 requested a review from a team as a code owner November 9, 2022 21:03
@ajschmidt8
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b94a595 into rapidsai:branch-22.12 Nov 9, 2022
@ajschmidt8 ajschmidt8 deleted the update-env-vars branch November 9, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raydouglass raydouglass raydouglass approved these changes

@jakirkham jakirkham jakirkham approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees
No one assigned
Labels
conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajschmidt8 @robertmaynard @jakirkham @raydouglass