Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce error handling verbosity in CI tests scripts #1204

Merged

Conversation

AjayThorve
Copy link
Member

This PR adds a less verbose trap method, for error handling to help ensure that we capture all potential error codes in our test scripts, and works as follows:

  • setting an environment variable, EXITCODE, with a default value of 0
  • setting a trap statement triggered by ERR signals which will set EXITCODE=1 when any commands return a non-zero exit code

cc @ajschmidt8

@AjayThorve AjayThorve requested a review from a team as a code owner February 8, 2023 18:11
@github-actions github-actions bot added the ci label Feb 8, 2023
@ajschmidt8 ajschmidt8 added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Feb 8, 2023
@AjayThorve
Copy link
Member Author

/merge

1 similar comment
@ajschmidt8
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 91d5cbd into rapidsai:branch-23.04 Feb 8, 2023
@AjayThorve AjayThorve deleted the ci/reduce-verbose-handling branch February 9, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants