Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat warnings as errors in Python documentation #1316

Merged
merged 17 commits into from
Aug 7, 2023
Merged

Treat warnings as errors in Python documentation #1316

merged 17 commits into from
Aug 7, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jul 31, 2023

Description

This will allow us to more easily audit the quality of our docs in CI going forward.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added doc Documentation non-breaking Non-breaking change labels Jul 31, 2023
@vyasr vyasr self-assigned this Jul 31, 2023
@vyasr vyasr requested review from a team as code owners July 31, 2023 21:17
@github-actions github-actions bot added Python Related to RMM Python API ci labels Jul 31, 2023
ajschmidt8
ajschmidt8 reviewed Aug 1, 2023
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question as below

@github-actions github-actions bot added the conda label Aug 2, 2023
@vyasr vyasr requested a review from ajschmidt8 August 2, 2023 00:12
@vyasr
Copy link
Contributor Author

vyasr commented Aug 2, 2023

same question as below

* [Fix all warnings in Python docs cudf#13789 (comment)](https://github.com/rapidsai/cudf/pull/13789#discussion_r1280653303)

Addressed it in the other PR. We're going to move towards make from sphinx-build everywhere.

ajschmidt8
ajschmidt8 requested changes Aug 3, 2023
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking while I investigate a potential error with the changes from the preview environments

@ajschmidt8
Copy link
Member

posted my findings in the cudf PR: rapidsai/cudf#13789 (comment)

@vyasr
Merge remote-tracking branch 'origin/branch-23.10' into docs/py_warn_…
d80667a 
…as_errors
@vyasr
Fix paths
7c91340
@vyasr
Merge remote-tracking branch 'origin/branch-23.10' into docs/py_warn_…
4b533cc 
…as_errors

# Conflicts:
#	conda/environments/all_cuda-118_arch-x86_64.yaml
#	conda/environments/all_cuda-120_arch-x86_64.yaml
@vyasr vyasr requested a review from ajschmidt8 August 4, 2023 20:44
@vyasr
Copy link
Contributor Author

vyasr commented Aug 7, 2023

/merge

@rapids-bot rapids-bot bot merged commit cd37245 into rapidsai:branch-23.10 Aug 7, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@bdice bdice bdice approved these changes

@wence- wence- wence- approved these changes

Assignees

@vyasr vyasr

Labels
ci conda doc Documentation non-breaking Non-breaking change Python Related to RMM Python API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vyasr @ajschmidt8 @wence- @bdice