Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to {{ stdlib("c") }} #1543

Merged
merged 3 commits into from
May 6, 2024
Merged

Migrate to {{ stdlib("c") }} #1543

merged 3 commits into from
May 6, 2024

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Apr 24, 2024 •
edited
Loading

The sysroot* syntax is getting phased out (conda-forge/conda-forge.github.io#2102).
The recommendation is to move to {{ stdlib("c") }}.

Ref rapidsai/build-planning#39

@hcho3 hcho3 requested a review from a team as a code owner April 24, 2024 19:07
@github-actions github-actions bot added the conda label Apr 24, 2024
jakirkham
jakirkham reviewed Apr 25, 2024
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip! 🙏

Think we need to add c_stdlib as well (as suggested below)

The other PRs likely need this as well

conda/recipes/librmm/conda_build_config.yaml Show resolved Hide resolved
conda/recipes/rmm/conda_build_config.yaml Show resolved Hide resolved
@jakirkham
Copy link
Member

Trying these changes out to see if this fixes CI

@jakirkham jakirkham added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Apr 25, 2024
@jakirkham
Copy link
Member

Ok that seems to be working. Going to mark this do not merge until we update the rest

@jakirkham jakirkham added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Apr 25, 2024
@hcho3 hcho3 removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label May 3, 2024
@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit e13b253 into rapidsai:branch-24.06 May 6, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@raydouglass raydouglass raydouglass approved these changes

@jakirkham jakirkham jakirkham approved these changes

Assignees
No one assigned
Labels
conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hcho3 @jakirkham @raydouglass @bdice