WIP: Copy bytes-like data to DeviceBuffer directly
#264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
force-pushed
the
use_frombytes
branch
4 times, most recently
from
b60c223
to
1b3e9d0
Compare
In cases where we know the data is flat and contiguous, build a `DeviceBuffer` from it directly and wrap it up in a Numba `DeviceNDArray`. This can be a bit more performant than the usual path given we can build the `DeviceBuffer` directly.
jakirkham
force-pushed
the
use_frombytes
branch
from
1b3e9d0
to
fd3bbb1
Compare
This was referenced Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where we know the data is flat, bytes-like, and contiguous, build a
DeviceBufferfrom it directly and wrap it up in a NumbaDeviceNDArray. This can be a bit more performant than the usual path given we can build theDeviceBufferdirectly.