Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship memory_resource_wrappers.hpp as package_data #715

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

shwina
Copy link
Contributor

@shwina shwina commented Feb 25, 2021

cuDF builds break after 230369d, because it cimports device_buffer.pxd, which in turn includes memory_resource_wrappers.hpp. This file isn't curerntly shipped as part of the RMM package. This PR ensures that we do ship it.

However, since PR #662 proposes removing this file entirely, we should undo this change in that PR. This PR is being submitted only to unblock CI in cuDF.

@shwina shwina requested a review from a team as a code owner February 25, 2021 15:01
@github-actions github-actions bot added the Python Related to RMM Python API label Feb 25, 2021
@kkraus14 kkraus14 added non-breaking Non-breaking change bug Something isn't working labels Feb 25, 2021
@kkraus14
Copy link
Contributor

@gpucibot merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change Python Related to RMM Python API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants