Add .clang-tidy and fix clang-tidy warnings #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
approved these changes
Sep 9, 2021
|
rerun tests |
harrism
added
the
5 - Ready to Merge
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Sep 16, 2021
There was an unneeded call to `device_uvector::release()` that did not use the return value. rapidsai/rmm#857 marks that function `[[nodiscard]]`, so removing this allows libcudf to compile after the RMM PR is merged. The `release()` is unnecessary because `prev_base_offsets` is passed by rvalue reference and therefore will be freed when the function exits (the uvector in the calling context it has been moved-from). Authors: - Mark Harris (https://github.com/harrism) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Jake Hemstad (https://github.com/jrhemstad) URL: #9237
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Sep 17, 2021
#857 introduced a few naming issues in debug builds due to parameter name changes. I rebuilt both C++ and Cython-generated code in debug mode and ran tests, both build and tests succeed now. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - MithunR (https://github.com/mythrocks) - Rong Ou (https://github.com/rongou) - Jake Hemstad (https://github.com/jrhemstad) URL: #875
7 tasks
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Jan 20, 2022
This PR is adding clang-tidy to cudf and adding the initial checks. Note more checks will be enabled in the future. Relevant PRs: * `rmm`: rapidsai/rmm#857 * `cuml`: rapidsai/cuml#1945 To do list: * [x] Add `.clang-tidy` file * [x] Add python script * [x] Apply `modernize-` changes * [x] Revert `cxxopts` changes * [x] Fixed Python parquet failures * [x] Ignore `cxxopts` file * [x] Ignore the `build/_deps` directories Splitting out the following into a separate PR so we can get the changes merged for 22.02 (#10064): * ~~[ ] Disable `clang-diagnostic-errors/warnings`~~ * ~~[ ] Fix include files being skipped~~ * ~~[ ] Set up CI script~~ * ~~[ ] Clean up python script~~ Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - Bradley Dice (https://github.com/bdice) - Nghia Truong (https://github.com/ttnghia) - David Wendt (https://github.com/davidwendt) - Mark Harris (https://github.com/harrism) - Vyas Ramasubramani (https://github.com/vyasr) URL: #9860
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a .clang-tidy configuration file. This does not add CI tests yet, but I wanted to get it ready to do so without forcing it on anyone. As-is, this PR will enable clang-tidy "yellow squiggles" if you use clangd in vscode.
Starting with these Checks:
Here is a list of warnings fixed
NOLINT lines have been added where fixes are unavailable, such as with necessary pointer arithmetic or
reinterpret_castcalls.I have a private branch of google test which adds NOLINT lines to suppress warnings caused by gtest's code. I plan to make a PR for this.
There are still a couple of outstanding warnings having to do with "easily swappable parameters" (e.g. when a function takes two sizes. Fixing these requires breaking API changes. Alternatively we could suppress them.)