Add clang-tidy to libcudf
#9860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codereport
added
2 - In Progress
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9860 +/- ##
================================================
- Coverage 10.49% 10.40% -0.09%
================================================
Files 119 119
Lines 20305 20557 +252
================================================
+ Hits 2130 2139 +9
- Misses 18175 18418 +243
Continue to review full report at Codecov.
|
|
rerun tests |
jrhemstad
reviewed
Jan 6, 2022
harrism
reviewed
Jan 19, 2022
bdice
reviewed
Jan 19, 2022
There was a problem hiding this comment.
A small number of questions/suggestions, none are particularly blocking so I am not requesting changes. Thanks for taking on this massive task @codereport!
bdice
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
I can't give this a second round of review from top to bottom right now but the changes I've seen (and updates from my previous pass) look good to me! Great work @codereport.
|
Waiting on #10008 to unlock CI |
ttnghia
approved these changes
Jan 19, 2022
|
BTW in my experience I find the clang-tidy misses a lot of opportunities for |
davidwendt
approved these changes
Jan 19, 2022
harrism
approved these changes
Jan 19, 2022
vyasr
approved these changes
Jan 20, 2022
|
rerun tests |
|
@gpucibot merge |
Merged
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 4, 2022
This PR runs [pyupgrade](https://github.com/asottile/pyupgrade) to modernize some syntax in the Python code base. (I am preparing a "better code" talk for our team that will reference this PR.) The kinds of modernizing changes that pyupgrade makes are similar in purpose to those made by clang-tidy (#9860), but for Python. These include things like: - Using literals for empty dicts `{}` and lists `[]`, because they are a bit faster and more readable than `dict()` or `list()` - Removing extra parentheses or braces wrapping generator expressions if not needed - Preferring format strings - Using canonical error names, e.g. `IOError` became an alias for `OSError` in Python 3.3. - Replacing the "new-style" class definitions like `class A(object):` with the simpler syntax `class A:` - Removing unnecessary `__future__` imports that were needed for Python 2 compatibility, like `print_function` and `division` - Using raw strings for regular expressions, to clarify intent and avoid extra escaping The [pyupgrade README](https://github.com/asottile/pyupgrade) has a long showcase of other rules. Notes for reviewers: - pyupgrade has a lot of opinions on how to use type annotations, and I'm not sure if I like all of them (some may have compatibility issues?). I have skipped over the type annotations for now, to set a more reasonable scope for this PR. See commit 54b16b9 (since reverted) for examples. Please let me know what you think about these changes and I may investigate them further in a follow-up PR! - I have not added this tool to our CI style checks via a pre-commit hook yet. That can be done in a follow-up PR if we agree that we would like these types of changes to be required in the future. - I used the argument `--py37-plus` to only perform changes that are compatible with Python 3.7+. - I can revert the changes to the vendored code in `versioneer.py` if desired. (It's pretty outdated anyway, it looks like we're using versioneer 0.18, released on January 1, 2017.) Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Charles Blackmon-Luca (https://github.com/charlesbluca) - AJ Schmidt (https://github.com/ajschmidt8) URL: #10141
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
This changeset is large, but it's not very substantial. It's all the automated fixes produced by clang-tidy using our script. The bulk of the changes are either adding `[[nodiscard]]` to many functions or changing const ref args to pass by value and then move in cases where the parameter is only used to set a value. There are also some places where clang-tidy preferred either more or less namespacing of objects depending on the current namespace. The goal is to enable clang-tidy in CI, which we made progress towards in #9860 but stalled in #10064. This PR contains the first set of changes that will required for such a check to pass. I've marked this PR as breaking because some of the functions now marked as `[[nodiscard]]` are public APIs, so if consumers were ignoring the return values they will now see warnings, and if they are compiling with warnings as errors then the builds will break. Contributes to #584 Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Bradley Dice (https://github.com/bdice) - Nghia Truong (https://github.com/ttnghia) URL: #15894
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding clang-tidy to cudf and adding the initial checks. Note more checks will be enabled in the future.
Relevant PRs:
rmm: Add .clang-tidy and fix clang-tidy warnings rmm#857cuml: [REVIEW] Enable clang tidy on cuML c++ sources cuml#1945To do list:
.clang-tidyfilemodernize-changescxxoptschangescxxoptsfilebuild/_depsdirectoriesSplitting out the following into a separate PR so we can get the changes merged for 22.02 (#10064):
[ ] Disableclang-diagnostic-errors/warnings[ ] Fix include files being skipped[ ] Set up CI script[ ] Clean up python script