Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add wheels workflow #877

Closed
wants to merge 29 commits into from
Closed

[WIP] add wheels workflow #877

wants to merge 29 commits into from

Conversation

quasiben
Copy link
Member

@quasiben quasiben commented Sep 19, 2022

Experimental PR to enable wheel building

@quasiben quasiben requested a review from a team as a code owner September 19, 2022 21:03
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some proposed cleanups

.github/build-scripts/patch-wheel.sh Outdated Show resolved Hide resolved
set -e
set -x

WHL=ucx_py-0.28.0a0+37.ge1f0547-cp38-cp38-manylinux_2_31_x86_64.whl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name needs to be provided by the calling entity.

.github/build-scripts/patch-wheel.sh Outdated Show resolved Hide resolved
.github/build-scripts/patch-wheel.sh Outdated Show resolved Hide resolved
.github/build-scripts/patch-wheel.sh Outdated Show resolved Hide resolved
.github/workflows/wheels.yml Outdated Show resolved Hide resolved
quasiben and others added 5 commits September 21, 2022 08:58
Co-authored-by: Lawrence Mitchell <lmitchell@nvidia.com>
Co-authored-by: Lawrence Mitchell <lmitchell@nvidia.com>
Co-authored-by: Lawrence Mitchell <lmitchell@nvidia.com>
Co-authored-by: Lawrence Mitchell <lmitchell@nvidia.com>
@@ -43,6 +41,23 @@ to_rewrite=$(ldd libuct_cuda.so | awk '/libcudart/ { print $1 }')
patchelf --replace-needed ${to_rewrite} libcudart-${hash}.so libuct_cuda.so
patchelf --add-rpath '$ORIGIN' libuct_cuda.so

find /lib/x86_64-linux-gnu/ -name "libnvidia-ml*.so.*" | xargs cp -P -t .
src=libnvidia-ml.so.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, it looks like libnvidia-ml.so also exists, so maybe start there (and adapt the previous line to libnvidia-ml*.so* ?

@sevagh
Copy link
Contributor

sevagh commented Oct 6, 2022

Closing this PR, superseded by #881

Thanks @wence- @quasiben!

@sevagh sevagh closed this Oct 6, 2022
@jakirkham jakirkham deleted the pip-wheels branch October 6, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants