You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Any API generating random numbers should use raft::random::RngState instead of the direct values for seed etc.
Implementations of these APIs should call RngState.advance accordingly so that they can be invoked several times without the user having to re-seed correctly (this is not trivial !)
Kernels should use DeviceState constructed from RngState in their signatures
Kernels should use <GeneratorClass>(device_state, subsequence) constructors instead of direct seed / subsequence constructors which are for advanced usage in RAFT
raft::random::RngState
instead of the direct values for seed etc.RngState.advance
accordingly so that they can be invoked several times without the user having to re-seed correctly (this is not trivial !)DeviceState
constructed fromRngState
in their signatures<GeneratorClass>(device_state, subsequence)
constructors instead of directseed
/subsequence
constructors which are for advanced usage in RAFTidx < M
may be==N
which would lead to undefined behavior. Maybe this should beidx < N
instead.The text was updated successfully, but these errors were encountered: