Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use top-k from RAFT #5

Closed
Tracked by #48
teju85 opened this issue Aug 16, 2022 · 0 comments · Fixed by #53
Closed
Tracked by #48

Use top-k from RAFT #5

teju85 opened this issue Aug 16, 2022 · 0 comments · Fixed by #53
Assignees
@dongxuy04
Labels
good first issue Good for newcomers tech-debt Cleanup tasks

Comments

@teju85
Copy link
Member

teju85 commented Aug 16, 2022

PR #3 introduces wholegraph/block_radix_topk.cuh which should be replaced with calls to the top-k kernels in RAFT.
@teju85 teju85 added good first issue Good for newcomers tech-debt Cleanup tasks labels Aug 16, 2022
@BradReesWork BradReesWork mentioned this issue Jul 10, 2023
Closed
@BradReesWork BradReesWork mentioned this issue Aug 3, 2023
Open
@chuangz0 chuangz0 mentioned this issue Aug 9, 2023
Merged
@rapids-bot rapids-bot bot closed this as completed in #53 Aug 17, 2023
rapids-bot bot pushed a commit that referenced this issue Aug 17, 2023
@chuangz0
PR: Use top-k from RAFT (#53)
58ba5a4 
Closes #5 
- fix bugs in `cpp/tests/wholegraph_ops/wholegraph_csr_weighted_sample_without_replacement_tests.cu` and `cpp/tests/graph_ops/csr_add_self_loop_utils.cu`
- use `raft::warp_sort( select_k)` to impl weighted_sampling_without_replacement, when sample_count>256, cub::DeviceSegmentSort is used for the implementation.
- remove `block_radix_topk.cuh`. replace `block_topk` in file `embedding_cache_func.cuh` with `raft::warp_sort`.

Authors:
  - Chuang Zhu (https://github.com/chuangz0)

Approvers:
  - https://github.com/dongxuy04
  - Brad Rees (https://github.com/BradReesWork)

URL: #53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dongxuy04 dongxuy04

Labels
good first issue Good for newcomers tech-debt Cleanup tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PR: Use top-k from RAFT chuangz0/wholegraph
2 participants
@teju85 @dongxuy04