Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor check to decouple with RR~ game framework #154

Merged
merged 10 commits into from
May 3, 2023
Merged

Refactor check to decouple with RR~ game framework #154

merged 10 commits into from
May 3, 2023

Conversation

yuokamoto
Copy link
Contributor

@yuokamoto yuokamoto commented May 1, 2023 •
edited
Loading

  • update dependency and check.
  • Make ROS2GameMode and ARRBaseRobot available without RRGameSingleton and etc
  • Rem use of ARRGameInstance which is just printing log
  • Decoupling with ARRPlayerController, which is only used with SceneDirector
  • update log level
  • Make RAPYUTA_USE_SCENE_DIRECTOR optional
  • Add RAPYUTA_SIM_VERBOSE

@yuokamoto yuokamoto requested a review from Tadinu May 1, 2023 06:45
@yuokamoto yuokamoto mentioned this pull request May 1, 2023
Closed
Tadinu
Tadinu approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@Tadinu Tadinu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the de-coupling refactoring, I only had some minor comments.
Just a note that these would mostly affect DataSynth app only, which is not in dev for now so should be fine.

Source/RapyutaSimulationPlugins/Private/Core/RRBaseActor.cpp Outdated Show resolved Hide resolved
Source/RapyutaSimulationPlugins/Private/Core/RRGameInstance.cpp Outdated Show resolved Hide resolved
Source/RapyutaSimulationPlugins/Private/Core/RRGameInstance.cpp Outdated Show resolved Hide resolved
Source/RapyutaSimulationPlugins/Private/Core/RRGameInstance.cpp Outdated Show resolved Hide resolved
Source/RapyutaSimulationPlugins/Private/Core/RRGameInstance.cpp Outdated Show resolved Hide resolved
Source/RapyutaSimulationPlugins/Private/Sensors/RR2DLidarComponent.cpp Outdated Show resolved Hide resolved
Source/RapyutaSimulationPlugins/Private/Sensors/RR3DLidarComponent.cpp Outdated Show resolved Hide resolved
Source/RapyutaSimulationPlugins/Private/Tools/OccupancyMapGenerator.cpp Outdated Show resolved Hide resolved
Source/RapyutaSimulationPlugins/Private/Tools/RRROS2SkeletalMeshStatePublisher.cpp Show resolved Hide resolved
Source/RapyutaSimulationPlugins/Private/Core/RRGameMode.cpp Outdated Show resolved Hide resolved
yuokamoto and others added 3 commits May 1, 2023 18:21
@yuokamoto
Update Source/RapyutaSimulationPlugins/Private/Sensors/RR3DLidarCompo…
5f4dc49 
…nent.cpp

Co-authored-by: Tadinu <ducanh.than@rapyuta-robotics.com>
@yuokamoto
Update Source/RapyutaSimulationPlugins/Private/Sensors/RR2DLidarCompo…
4ce28bc 
…nent.cpp

Co-authored-by: Tadinu <ducanh.than@rapyuta-robotics.com>
@yuokamoto
Update Source/RapyutaSimulationPlugins/Private/Core/RRROS2GameMode.cpp
89f1f65 
Co-authored-by: Tadinu <ducanh.than@rapyuta-robotics.com>
@Tadinu Tadinu changed the title refactor check Refactor check to decouple with RR~ game framework May 2, 2023
@yuokamoto yuokamoto merged commit 213530d into devel May 3, 2023
@yuokamoto yuokamoto deleted the refactor_dependency branch May 3, 2023 04:11
@Tadinu Tadinu mentioned this pull request May 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tadinu Tadinu Tadinu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuokamoto @Tadinu