Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Migrate rarimo/nft-checkout to evm-swap-v2 contracts and implement @rarimo/shared, @rarimo/bridge, @rarimo/swap packages to split logic and make basement for the Rarimo protocol bridge simple bridge features #31

Merged
merged 32 commits into from
Jun 1, 2023

Conversation

napalmpapalam
Copy link
Contributor

No description provided.

@napalmpapalam napalmpapalam marked this pull request as draft May 3, 2023 09:35
@napalmpapalam napalmpapalam changed the title WIP: Feature: Migrate rarimo/nft-checkout to evm-swap-v2 contracts and implement @rarimo/core package to make basement for the Rarimo protocol bridge simple bridge features WIP: Feature: Migrate rarimo/nft-checkout to evm-swap-v2 contracts and implement @rarimo/shared, @rarimo/bridge, @rarimo/swap packages to split logic and make basement for the Rarimo protocol bridge simple bridge features May 10, 2023
@napalmpapalam napalmpapalam changed the title WIP: Feature: Migrate rarimo/nft-checkout to evm-swap-v2 contracts and implement @rarimo/shared, @rarimo/bridge, @rarimo/swap packages to split logic and make basement for the Rarimo protocol bridge simple bridge features Feature: Migrate rarimo/nft-checkout to evm-swap-v2 contracts and implement @rarimo/shared, @rarimo/bridge, @rarimo/swap packages to split logic and make basement for the Rarimo protocol bridge simple bridge features May 29, 2023
@napalmpapalam napalmpapalam marked this pull request as ready for review May 29, 2023 09:51
@napalmpapalam napalmpapalam changed the base branch from main to dev May 29, 2023 10:32
packages/swap/src/swappers/evm/get-execute-data.ts Outdated Show resolved Hide resolved
packages/swap/src/swappers/evm/get-execute-data.ts Outdated Show resolved Hide resolved
packages/swap/src/types/swapper.ts Outdated Show resolved Hide resolved
packages/bridge/src/types/bridger.ts Show resolved Hide resolved
packages/bridge/src/types/token.ts Outdated Show resolved Hide resolved
packages/shared/src/helpers/general.ts Show resolved Hide resolved
Copy link
Contributor

@ihordiachenko ihordiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

packages/bridge/src/bridgers/evm/get-destination-tx.ts Outdated Show resolved Hide resolved
packages/bridge/src/bridgers/evm/get-destination-tx.ts Outdated Show resolved Hide resolved
packages/bridge/src/types/bridger.ts Outdated Show resolved Hide resolved
packages/nft-checkout/src/const/tokens.ts Outdated Show resolved Hide resolved
packages/bridge/src/bridger.ts Outdated Show resolved Hide resolved
packages/bridge/src/entities/token.ts Outdated Show resolved Hide resolved
packages/provider/src/errors/provider.ts Outdated Show resolved Hide resolved
packages/swap/src/swappers/evm/get-execute-data.ts Outdated Show resolved Hide resolved
packages/nft-checkout/src/entities/payment-token.ts Outdated Show resolved Hide resolved
@napalmpapalam napalmpapalam changed the base branch from dev to main June 1, 2023 13:00
ardier16

This comment was marked as duplicate.

Copy link

@ardier16 ardier16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job 🚀

@napalmpapalam napalmpapalam merged commit ad2f297 into main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants