Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect word #1

Closed
Topmost2020 opened this issue Jan 14, 2022 · 1 comment
Closed

Incorrect word #1

Topmost2020 opened this issue Jan 14, 2022 · 1 comment

Comments

@Topmost2020
Copy link

Going through the README.md file in the first chapter of your book, I couldn't stopping wondering how you came up with this amazing book. Obviously, it would be an understatement to say this book is a great piece. Thumbs up.

However, I noticed two incorrect words, precisely "comotabible" and "avaiable" in the 4th and 5th paragraph of Jupiter Notebook respectively.

Asides that, you have done a perfect job and I can't wait to get your book.
@rasbt
Copy link
Owner

rasbt commented Jan 14, 2022

Thanks so much for the kind words! Thanks also for pointing out these typos, just went ahead and fixed them!

@rasbt rasbt closed this as completed Jan 14, 2022
akshayvkt added a commit to akshayvkt/machine-learning-book that referenced this issue Oct 26, 2023
@akshayvkt
Update ch13_part3_lightning.ipynb
397818f 
1. Updated the deprecated modules (training_epoch_end and validation_epoch_end) to on_train_epoch_end and on_validation_epoch_end. 

2. Removed 'outs argument from both functions because the model fails to train with the outs argument in the function.

The model now successfully trains with these changes. I'm certain change rasbt#1 is needed, not sure about change rasbt#2 but updating that let me train the model and not error out.
@akshayvkt akshayvkt mentioned this issue Oct 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rasbt @Topmost2020