Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColumnSelector now works with pandas dataframes #378

Merged
merged 1 commit into from
May 3, 2018

Conversation

manugarri
Copy link
Contributor

Description

This PR allows ColumnSelector to select columns on Pandas Dataframes.

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran nosetests ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., nosetests ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 90.965% when pulling 7d4792a on manugarri:pandas_col_selector into 2ced0d4 on rasbt:master.

@rasbt
Copy link
Owner

rasbt commented May 3, 2018

That's great, thanks for the PR!

@rasbt rasbt merged commit 9722b43 into rasbt:master May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants