Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix when using refit=False #385

Merged
merged 1 commit into from
May 20, 2018
Merged

bug fix when using refit=False #385

merged 1 commit into from
May 20, 2018

Conversation

selay01
Copy link
Contributor

@selay01 selay01 commented May 20, 2018

bug fix when using refit=False

Description

Related issues or pull requests

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran nosetests ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., nosetests ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

bug fix when using refit=False
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.205% when pulling 08e58b2 on selay01:patch-2 into c6685e6 on rasbt:master.

@rasbt
Copy link
Owner

rasbt commented May 20, 2018

Also here, thanks a lot for catching that!

@rasbt rasbt merged commit a02c344 into rasbt:master May 20, 2018
@selay01 selay01 deleted the patch-2 branch May 20, 2018 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants