Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a support_only param to the association_rules function #421

Merged
merged 3 commits into from
Jul 21, 2018

Conversation

rasbt
Copy link
Owner

@rasbt rasbt commented Jul 20, 2018

Description

Added a support_only to the association_rules function, which allow constructing association rules (based on the support metric only) for cropped input DataFrames that don't contain a complete set of antecedent and consequent support values.

Related issues or pull requests

Fixes #390

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran nosetests ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., nosetests ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@pep8speaks
Copy link

pep8speaks commented Jul 20, 2018

Hello @rasbt! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on July 21, 2018 at 01:06 Hours UTC

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 91.312% when pulling 1c7f00d on assoc-rule into e760cd4 on master.

@rasbt rasbt merged commit d2aedb3 into master Jul 21, 2018
@rasbt rasbt deleted the assoc-rule branch November 10, 2018 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants