Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default solver of PCA to svd #474

Merged
merged 1 commit into from
Dec 1, 2018
Merged

change default solver of PCA to svd #474

merged 1 commit into from
Dec 1, 2018

Conversation

rasbt
Copy link
Owner

@rasbt rasbt commented Dec 1, 2018

Description

Changed the default solver in PrincipalComponentAnalysis to 'svd' instead of 'eigen' to improve numerical stability.

Related issues or pull requests

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran nosetests ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., nosetests ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@pep8speaks
Copy link

Hello @rasbt! Thanks for submitting the PR.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.8% when pulling a61f61a on pca-pipeline into 93dee32 on master.

@rasbt rasbt merged commit c9c949b into master Dec 1, 2018
@rasbt rasbt deleted the pca-pipeline branch June 10, 2019 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants