Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort eigvecs in PCA #477

Merged
merged 2 commits into from
Dec 3, 2018
Merged

Sort eigvecs in PCA #477

merged 2 commits into from
Dec 3, 2018

Conversation

rasbt
Copy link
Owner

@rasbt rasbt commented Dec 3, 2018

Description

The eigenvectors maybe have not been sorted in certain edge cases if solver was 'eigen' in PrincipalComponentAnalysis.

Related issues or pull requests

Fixes #476

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran nosetests ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., nosetests ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@pep8speaks
Copy link

Hello @rasbt! Thanks for submitting the PR.

@rasbt rasbt changed the title sort eigvecs Sort eigvecs in PCA Dec 3, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.816% when pulling 25adf46 on sorteigvec into a4bcab8 on master.

@rasbt rasbt merged commit 4a9e5e0 into master Dec 3, 2018
@rasbt rasbt deleted the sorteigvec branch June 10, 2019 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants