Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up compare_dict related unit tests #547

Merged
merged 1 commit into from
Jun 2, 2019
Merged

Clean up compare_dict related unit tests #547

merged 1 commit into from
Jun 2, 2019

Conversation

rasbt
Copy link
Owner

@rasbt rasbt commented Jun 2, 2019

Description

Cleans up some unit tests

Related issues or pull requests

Fixes #536

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran PYTHONPATH='.' pytest ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.1% when pulling 5158a02 on unit-tests-dict into 0541dd0 on master.

@rasbt rasbt merged commit cfea06a into master Jun 2, 2019
@rasbt rasbt deleted the unit-tests-dict branch June 10, 2019 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unit tests - actual and expected parameters transposed in several tests
2 participants