Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible to change the figure heigh and width #555

Merged
merged 5 commits into from
Jun 20, 2019
Merged

Conversation

kazyka
Copy link
Contributor

@kazyka kazyka commented Jun 19, 2019

Description

Related issues or pull requests

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran PYTHONPATH='.' pytest ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@pep8speaks
Copy link

pep8speaks commented Jun 19, 2019

Hello @kazyka! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-06-20 13:46:21 UTC

@coveralls
Copy link

coveralls commented Jun 19, 2019

Coverage Status

Coverage decreased (-0.03%) to 92.045% when pulling 99aeeab on kazyka:patch-1 into d9b5c40 on rasbt:master.

@rasbt
Copy link
Owner

rasbt commented Jun 20, 2019

Thanks for the fix, and the PR! I addressed the documentation-specific points and it should be good to merge now.

@rasbt rasbt merged commit 487c802 into rasbt:master Jun 20, 2019
@kazyka
Copy link
Contributor Author

kazyka commented Jun 20, 2019

Awesome, sorry for the sloppy edits, I have a deadline with my master thesis due in a couple weeks. I have closed my comment. Hopefully I did it correct :)

@kazyka kazyka deleted the patch-1 branch June 20, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants