add support for newer pandas sparse dataframes in frequent_patterns #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparseDataFrame has been deprecated, pandas now recommands to create standard DataFrames and store sparse Series as SparseArray. This allows to combine both dense and sparse columns. Improve valid_input_check with sparse values; it previously uncompressed the whole dataframe to check for invalid values, which defeats its purpose. It now only checks existing values, which prevents memory error, and is also much faster. Update apriori.ipynb notebook to use the new pandas sparse DataFrame.
rasbt
reviewed
Nov 5, 2019
Contrary to what I thought in 0a8fa8f, this issue is still not fixed.
|
@rasbt I will investigate travis failures, but I have an unrelated question: are issues labelled stat479 reserved for your students? I have some ideas to improve fpgrowth/fpmax with sparse input, but do not want to interfere here. |
Thanks, and no rush!
No worries; the I have some honors students who would like to learn how to contribute to open source projects; these are simply ones I tagged as suggestions but no one is working on these right now. |
|
Looks good to me know. Thanks again for another great PR! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SparseDataFrame has been deprecated, pandas 0.24 recommands to create
standard DataFrames and store sparse Series as SparseArray. This
allows to combine both dense and sparse columns.
Improve
valid_input_checkwith sparse values; it previously uncompressedthe whole dataframe to check for invalid values, which defeats its purpose.
It now only checks existing values, which prevents memory error, and is
also much faster.
Update apriori.ipynb notebook to use the new pandas sparse DataFrame.
Related issues or pull requests
Pull Request Checklist
./docs/sources/CHANGELOG.mdfile (if applicable)./mlxtend/*/testsdirectories (if applicable)mlxtend/docs/sources/(if applicable)PYTHONPATH='.' pytest ./mlxtend -svand make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g.,PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)flake8 ./mlxtend