-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #620 Add a warning about non Boolean inputs #934
Conversation
Hello @NimaSarajpoor! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-05-14 18:02:17 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR! Just a small suggestion
I just added a Changelog entry. You may have to do a |
@rasbt I did not know that I should have added this small change to |
No worries and thanks for the PR. Let me run the tests and then I think it should be good to merge |
Add warning about not bool type. This PR addresses issue #620.