Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #620 Add a warning about non Boolean inputs #934

Merged
merged 8 commits into from
May 24, 2022
Merged

Fixes #620 Add a warning about non Boolean inputs #934

merged 8 commits into from
May 24, 2022

Conversation

NimaSarajpoor
Copy link
Contributor

Add warning about not bool type. This PR addresses issue #620.

@pep8speaks
Copy link

pep8speaks commented May 9, 2022

Hello @NimaSarajpoor! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-05-14 18:02:17 UTC

Copy link
Owner

@rasbt rasbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR! Just a small suggestion

mlxtend/frequent_patterns/fpcommon.py Outdated Show resolved Hide resolved
@rasbt
Copy link
Owner

rasbt commented May 14, 2022

I just added a Changelog entry. You may have to do a git pull before you make any additional commits. Btw. I just checked out the Deprecation warning, and it works for all three algos. Nice! I think after updating the message, it is good to merge!

@NimaSarajpoor
Copy link
Contributor Author

@rasbt
Thanks for your support and guidance! I thinks things should be good now.

I did not know that I should have added this small change to CHANGELOG.md. So, if I understand correctly, (almost?) any change to this library should be recorded in CHANGELOG.md after they are finalized right before merging the PR.

@rasbt
Copy link
Owner

rasbt commented May 24, 2022

No worries and thanks for the PR. Let me run the tests and then I think it should be good to merge

@rasbt rasbt merged commit d6eced4 into rasbt:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants