Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icononbuttons(Hacktoberfest) #25

Merged
merged 2 commits into from
Oct 22, 2023
Merged

Icononbuttons(Hacktoberfest) #25

merged 2 commits into from
Oct 22, 2023

Conversation

HamnaJabbar
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Oct 22, 2023

@HamnaJabbar is attempting to deploy a commit to the RAS - CUI Lahore Team on Vercel.

A member of the Team first needs to authorize it.

@IbraheemHaseeb7
Copy link
Contributor

hey @HamnaJabbar

For the buttons that do not have any link in href and are set to # can you keep them to be view profile for now or perhaps some icon that shows that this button does not lead to any new link? The rest looks perfect 🚀🙌

@HamnaJabbar
Copy link
Contributor Author

Hi @IbraheemHaseeb7 !
I replaced the insta icon with fa-user icon from font-awesome library for cards having no link.
Have a look.

@IbraheemHaseeb7 IbraheemHaseeb7 merged commit 7dd42f8 into rascui:main Oct 22, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest accepted hacktoberfest Accepted for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HamnaJabbar @IbraheemHaseeb7