Update to work with l5.4 out the box #83
Conversation
| @@ -14,7 +14,7 @@ | |||
| "RachidLaasri\\LaravelInstaller\\": "src/" | |||
| }, | |||
| "files": [ | |||
| "src/functions.php" | |||
There was a problem hiding this comment.
I thought it better to have this in the Helpers folder.
readme.md
Outdated
|
|
||
| ## Installation | ||
| * [Laravel 5.1, 5.2, 5.3, 5.4 or newer](https://laravel.com/docs/installation) |
There was a problem hiding this comment.
You may want to link the version numbers to different version of your package that will work with those if it arises.
readme.md
Outdated
| ``` | ||
| composer update | ||
| ```bash | ||
| composer require rachidlaasri/laravel-installer |
There was a problem hiding this comment.
I thought it best to not have the user touch their composer.json and have this done and installed in swoop.
| @@ -34,7 +34,6 @@ | |||
| | | |||
| */ | |||
| 'permissions' => [ | |||
| 'storage/app/' => '775', | |||
There was a problem hiding this comment.
This folder is no longer part of Laravel 5.3+ and will cause php function error on this.
| @@ -24,21 +24,18 @@ class LaravelInstallerServiceProvider extends ServiceProvider | |||
| public function register() | |||
| { | |||
| $this->publishFiles(); | |||
|
|
|||
| $this->loadRoutesFrom(__DIR__.'/../routes.php'); | |||
| $this->loadRoutesFrom(__DIR__.'/../routes/web.php'); | |||
There was a problem hiding this comment.
Moved into routes folder to follow L5.3+ conventions and moved web routes to we.php file as well. This may be helpful in the future in the event you extend this to an api for whatever crazy reasons :)
| CanInstall::class | ||
| ]); | ||
| $router->middlewareGroup('install',[CanInstall::class]); | ||
| $router->middlewareGroup('update',[CanUpdate::class]); |
There was a problem hiding this comment.
Registered update middleware.
Removed un-needed RedirectInstall addition to web middleware.
| @@ -50,18 +47,18 @@ protected function publishFiles() | |||
| { | |||
| $this->publishes([ | |||
| __DIR__.'/../Config/installer.php' => base_path('config/installer.php'), | |||
| ]); | |||
| ], 'laravelinstaller'); | |||
There was a problem hiding this comment.
Added publishing tags to make much cleaner command line install and to solve other reported issues.
| @@ -0,0 +1,46 @@ | |||
| //colors | |||
There was a problem hiding this comment.
Added SASS for easy customizations.
| @@ -0,0 +1,46 @@ | |||
| //colors | |||
There was a problem hiding this comment.
Added SCSS for easy customizations.
ghost
merged commit 
|
This is looking amazing! Thanks! |
Debugged the service provider file, solved the issues reported regarding middleware and missing classes.
Moved routes.php to routes/web.php.
Updated artisan publish tag.
Added MIT license file.
Updated readme.
Bumped up the tag to 2.1 for packagist.
Tested as working on L5.4
Thank you for all the hard work!