backend/drm: Allow interlaced modes whose resolution is unique #1
Conversation
This partially reverts the filtering-out of interlaced modes, but we still remove those whose resolution matches a progressive mode (at least until wlr-randr and arandr can be taught to distinguish them).
|
That'll work for now. It would be nice to offer all modes explicitly, but not for release. |
|
I'd suggest this doesn't get merged until the release is out of the way - I don't want to be changing wlroots this weekend... |
|
Ah, I was hoping to get it in before the release so that TV Out would not stop working. |
|
Is it a regression over the bullseye release if it isn't in? What is Gordon's position on it? We're well past the point at which we should be making significant changes to core software; we've already had one break post-freeze caused by pulling in upstream changes to wlroots/wayfire at the last minute, and I'd really prefer to avoid the possibility of another. Unless this is a) a completely risk-free change and b) fixing a showstopping bug, it really shouldn't be going in post release freeze. It can be pulled in on automatic updates once it has had sufficient testing. |
|
I suppose the main risks are:
The workaround is to drop back to X11 (or text console) when using TV Out on a Pi4 or Pi5. |
|
TV Out on Pi 5 requires soldering, IIRC - it doesn't have the connector on the board, so this is really only relevant for Pi 4 in most use cases? |
|
Yes, or some older HDMI TVs with 1080i but not 1080p. But I must admit I haven't tested that either. |
This partially reverts the filtering-out of interlaced modes, but we still remove those whose resolution matches a progressive mode (at least until wlr-randr and arandr can be taught to distinguish them).
Need this for TV Out to work on Pi4 and Pi5.