FKMS overscan support. #3090
Merged
FKMS overscan support. #3090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit eda6887 upstream. The in the kernel-doc header did not match the function name. Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> Reviewed-by: Eric Anholt <eric@anholt.net> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://patchwork.freedesktop.org/patch/msgid/20181206142439.10441-2-boris.brezillon@bootlin.com
Commit 56406e1 upstream. All margins are expressed in pixels. Clarify that in the doc. Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> Reviewed-by: Eric Anholt <eric@anholt.net> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://patchwork.freedesktop.org/patch/msgid/20181206142439.10441-3-boris.brezillon@bootlin.com
Commit 6c4f52d upstream. TV margins properties can only be added as part of the SDTV TV connector properties creation, but we might need those props for HDMI TVs too, so let's move the margins props creation in a separate function and expose it to drivers. We also add an helper to attach margins props to a connector. Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> Reviewed-by: Eric Anholt <eric@anholt.net> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://patchwork.freedesktop.org/patch/msgid/20181206142439.10441-4-boris.brezillon@bootlin.com
Commit 666e735 upstream. Applyin margins is just a matter of scaling all planes appropriately and adjusting the CRTC X/Y offset to account for the left/right/top/bottom borders. Create a vc4_plane_margins_adj() function doing that and call it from vc4_plane_setup_clipping_and_scaling() so that we are ready to attach margins properties to the HDMI connector. Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> Reviewed-by: Eric Anholt <eric@anholt.net> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://patchwork.freedesktop.org/patch/msgid/20181206142439.10441-5-boris.brezillon@bootlin.com
Commit db99953 upstream. Now that the plane code takes the margins setup into account, we can safely attach margin props to the HDMI connector. We also take care of filling AVI infoframes correctly to expose the top/botton/left/right bar. Note that those margin props match pretty well the overscan_{left,right,top,bottom} properties defined in config.txt and parsed by the VC4 firmware. Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> Reviewed-by: Eric Anholt <eric@anholt.net> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://patchwork.freedesktop.org/patch/msgid/20181206142439.10441-6-boris.brezillon@bootlin.com
Allows for overscan to be configured under FKMS. NB This is rescaling the planes, not reducing the size of the display mode. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
The compiler is warning that default_zpos can be used uninitialised as there is no default case to catch all plane types. No other plane types should ever be presented to vc4_fkms_plane_init, but add a default case regardless. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
|
Odd sized cursor after screen saver resolved. Dispmanx does that job for us anyway, so ditching it gives the right results. Branch/PR updated. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jul 23, 2019
kernel: overlays: Add PCF2129 RTC See: #1190 kernel: overlays: dpi18 and dpi24 vc4 compatibility kernel: overlays: Add i2c0 and i2c1 for regularity kernel: Pisound: Remove spinlock usage around spi_sync See: raspberrypi/linux#3069 kernel: configs: Enable iio driver for TI ADS1015 See: raspberrypi/linux#3083 kernel: bcm2711_defconfig: enable PCI portbus support (and implicitly, PCIe AER) See: raspberrypi/linux#3086 kernel: FKMS hdmi_timings settings See: raspberrypi/linux#3082 kernel: overlays: audremap: Support GPIOs 18 & 19 See: #1178 kernel: FKMS overscan support See: raspberrypi/linux#3090 firmware: Change order of display remapping for default display number firmware: AWB: Set default number of stats regions for RPi AWB See: #1198 firmware: Fix composite interrupt HVS channel firmware: scalarlib: Fix width setting for SCALERLIB_PIXEL_FORMAT_YUV10COL firmware: vcmailbox: Add a new SET_AUDIO_LDO_STATE mailbox command firmware: Add mailbox call to report the HDMI timings firmware: H264: Set the decoder cache AXI burst length to the same as the encoder firmware: gencmd: Fix gencmd max result length firmware: bootloader_config: New gencmd to read the EEPROM config firmware: pwm_audio: Use PWM1 on BCM2838 unless remapped See: #1178
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Jul 23, 2019
kernel: overlays: Add PCF2129 RTC See: raspberrypi/firmware#1190 kernel: overlays: dpi18 and dpi24 vc4 compatibility kernel: overlays: Add i2c0 and i2c1 for regularity kernel: Pisound: Remove spinlock usage around spi_sync See: raspberrypi/linux#3069 kernel: configs: Enable iio driver for TI ADS1015 See: raspberrypi/linux#3083 kernel: bcm2711_defconfig: enable PCI portbus support (and implicitly, PCIe AER) See: raspberrypi/linux#3086 kernel: FKMS hdmi_timings settings See: raspberrypi/linux#3082 kernel: overlays: audremap: Support GPIOs 18 & 19 See: raspberrypi/firmware#1178 kernel: FKMS overscan support See: raspberrypi/linux#3090 firmware: Change order of display remapping for default display number firmware: AWB: Set default number of stats regions for RPi AWB See: raspberrypi/firmware#1198 firmware: Fix composite interrupt HVS channel firmware: scalarlib: Fix width setting for SCALERLIB_PIXEL_FORMAT_YUV10COL firmware: vcmailbox: Add a new SET_AUDIO_LDO_STATE mailbox command firmware: Add mailbox call to report the HDMI timings firmware: H264: Set the decoder cache AXI burst length to the same as the encoder firmware: gencmd: Fix gencmd max result length firmware: bootloader_config: New gencmd to read the EEPROM config firmware: pwm_audio: Use PWM1 on BCM2838 unless remapped See: raspberrypi/firmware#1178
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5 patches backported from 5.1, and then implementing margins for FKMS.
You can test with either modetest (from https://gitlab.freedesktop.org/mesa/drm/tree/master/tests/modetest), with
modetest -M vc4 -w 51:"top margin":50replace "top" with "bottom", "left" or "right" as appropriate.
51 is the DRM connector ID, and can be determined with
or from xrandr
NB because the primary (background) plane isn't redrawn at this point, your mouse cursor won't now align with things. Change resolution using lxrandr or similar, or otherwise force a full screen redraw, and your new settings should take effect.