Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to upstream cpufreq driver for Pi 1 #3815

Merged
merged 2 commits into from
Aug 25, 2020

Conversation

popcornmix
Copy link
Collaborator

This switches to upstream cpufreq driver for Pi 1. Downstream driver is now unused and can be dropped going forwards.

This also removes the "Only report integer pll divisor frequencies" commit which isn't required after latest rpi-update firmware which relaxes conditions on arm frequency. This is necessary on pi1 and typically the normal and overclock frequencies (e.g. 700 and 1000) are not both supported and get quantized to same frequency.

I believe having this PR without latest firmware is safe, but suboptimal as kernel will ask for frequencies not directly supported by firmware that will be rounded down. Max and Min frequencies should be okay, so probably not a major issue.

Marked as WIP while I test.

@popcornmix popcornmix changed the title WIP: Switch to upstream cpufreq driver for Pi 1 Switch to upstream cpufreq driver for Pi 1 Aug 25, 2020
@popcornmix
Copy link
Collaborator Author

Removed WIP. Tested on Pi1, Pi3 and Pi4.
Pi4 kernel change with older firmware is okay - I seem arm ask for frequencies spaced at 100MHz intervals and firmware rounds down to 1500/1000/750/600. With latest firmware and kernel you get the 100MHz intervals requested.

@pelwell pelwell merged commit 31d197d into raspberrypi:rpi-5.4.y Aug 25, 2020
HiassofT added a commit to HiassofT/LibreELEC.tv that referenced this pull request Aug 25, 2020
see raspberrypi/linux#3815

Signed-off-by: Matthias Reichl <hias@horus.com>
@popcornmix popcornmix deleted the cpufreq_pi1 branch August 26, 2020 09:46
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this pull request Aug 26, 2020
See: raspberrypi/linux#3815

kernel: staging: vc04_services: ISP: Fix dmabuf error check in S_CTRL
See: raspberrypi/linux#3813

kernel: overlays: Updated MCP3008 compatible strings.
See: raspberrypi/linux#3807

kernel: configs: Add I2C_HID=m
See: https://www.raspberrypi.org/forums/viewtopic.php?f=107&t=283241

kernel: ARM: dts: bcm2711: Enable support for DDR52 eMMC
See: raspberrypi/linux#3802

kernel: media: dvbsky: use a single mutex and state buffers for all R/W ops
See: raspberrypi/linux#3809
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Aug 26, 2020
See: raspberrypi/linux#3815

kernel: staging: vc04_services: ISP: Fix dmabuf error check in S_CTRL
See: raspberrypi/linux#3813

kernel: overlays: Updated MCP3008 compatible strings.
See: raspberrypi/linux#3807

kernel: configs: Add I2C_HID=m
See: https://www.raspberrypi.org/forums/viewtopic.php?f=107&t=283241

kernel: ARM: dts: bcm2711: Enable support for DDR52 eMMC
See: raspberrypi/linux#3802

kernel: media: dvbsky: use a single mutex and state buffers for all R/W ops
See: raspberrypi/linux#3809
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants